← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1634086] Re: fwaas v2 update firewall group with non exist port hit internal error

 

Reviewed:  https://review.openstack.org/387328
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=aabd3a42d35b4b9e54706e1d51c79f8bf4203205
Submitter: Jenkins
Branch:    master

commit aabd3a42d35b4b9e54706e1d51c79f8bf4203205
Author: ZhaoBo <zhaobo6@xxxxxxxxxx>
Date:   Mon Oct 17 17:52:41 2016 +0800

    Catch the integrityError when update firewall group with non exist port
    
    When create/update firewall group should verify the port_id exist in
    current system.
    
    This patch add check in update firewall group operation to verify
    the input ports are exist.
    
    Change-Id: I98862ff46eb80b5f516dd02a0ab179017825a9c9
    Closes-Bug: #1634086


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1634086

Title:
  fwaas v2 update firewall group with non exist port hit internal error

Status in neutron:
  Fix Released

Bug description:
  I use RESTapi to update a firewall group with non exist port_id,like:
      {
          "firewall_group": {
              "ports": ["8cde8d37-c860-4a28-999a-68ab0dbdf194",$[NON_EXIST_PORT_ID]]
          }
      }

  The neutron server hit internal error.

  2016-10-17 16:36:22.217 TRACE neutron.api.v2.resource
  ^[[01;35m^[[00mDBReferenceError: (pymysql.err.IntegrityError) (1452,
  u'Cannot add or update a child row: a foreign key constraint fails
  (`neutron`.`firewall_group_port_associations_v2`, CONSTRAINT
  `firewall_group_port_associations_v2_ibfk_2` FOREIGN KEY (`port_id`)
  REFERENCES `ports` (`id`) ON DELETE CASCADE)') [SQL: u'INSERT INTO
  firewall_group_port_associations_v2 (firewall_group_id, port_id)
  VALUES (%(firewall_group_id)s, %(port_id)s)'] [parameters:
  ({'port_id': u'8cde8d37-c860-4a28-999a-68ab0dbdf194',
  'firewall_group_id': u'2932b3d9-3a7b-48a1-a16c-bf9f7b2751a5'},
  {'port_id': u'fa690dcc-71eb-4154-6666-ffffffffffff',
  'firewall_group_id': u'2932b3d9-3a7b-48a1-a16c-bf9f7b2751a5'})]

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1634086/+subscriptions


References