yahoo-eng-team team mailing list archive

[wang yinfeng <batman.wang@xxxxxx>]

Public bug reported:

Hi,

When I check the QoS API reference, I have question about the max_burst_kbps parameter in the QoS bandwidth limit rule API, the parameter name(max_burst_kbps) means it's measured by the kbps, not measured by the size(kbits).
But after I checked the implementation, with OVS for example, QoS setting call the following fuction in OVS, the burst means the buffer size, not the speed, and I don't see any translate for this parameter in neutron code.

/* Attempts to set input rate limiting (policing) policy, such that up to
 * 'kbits_rate' kbps of traffic is accepted, with a maximum accumulative burst
 * size of 'kbits' kb. */
int
netdev_set_policing(struct netdev *netdev, uint32_t kbits_rate,
                    uint32_t kbits_burst)
{
    return (netdev->netdev_class->set_policing
            ? netdev->netdev_class->set_policing(netdev,
                    kbits_rate, kbits_burst)
            : EOPNOTSUPP);
}

also, when I checked the following devref, has the following description:
• QosBandwidthLimitRule: defines the instance-egress bandwidth limit rule type, characterized by a max kbps and a max burst kbits.
<http://docs.openstack.org/developer/neutron/devref/quality_of_service.html> 

So, I think the max_burst_kbps is actually means max burst kbits, am I right?
And if I'm correct, is it possible to change the parameter name to max_burst_kbits?

Correct me if I'm wrong.

thanks.

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: api api-ref qos

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1637977

Title:
  QoS API parameter name issue, max_burst_kbps should be
  max_burst_kbits?

Status in neutron:
  New

Bug description:
  Hi,

  When I check the QoS API reference, I have question about the max_burst_kbps parameter in the QoS bandwidth limit rule API, the parameter name(max_burst_kbps) means it's measured by the kbps, not measured by the size(kbits).
  But after I checked the implementation, with OVS for example, QoS setting call the following fuction in OVS, the burst means the buffer size, not the speed, and I don't see any translate for this parameter in neutron code.

  /* Attempts to set input rate limiting (policing) policy, such that up to
   * 'kbits_rate' kbps of traffic is accepted, with a maximum accumulative burst
   * size of 'kbits' kb. */
  int
  netdev_set_policing(struct netdev *netdev, uint32_t kbits_rate,
                      uint32_t kbits_burst)
  {
      return (netdev->netdev_class->set_policing
              ? netdev->netdev_class->set_policing(netdev,
                      kbits_rate, kbits_burst)
              : EOPNOTSUPP);
  }

  also, when I checked the following devref, has the following description:
  • QosBandwidthLimitRule: defines the instance-egress bandwidth limit rule type, characterized by a max kbps and a max burst kbits.
  <http://docs.openstack.org/developer/neutron/devref/quality_of_service.html> 

  So, I think the max_burst_kbps is actually means max burst kbits, am I right?
  And if I'm correct, is it possible to change the parameter name to max_burst_kbits?

  Correct me if I'm wrong.

  thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1637977/+subscriptions