← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1638273] [NEW] find_child_pids crashes under non-english locals

 

Public bug reported:

Traceback available at [1].

The function execute() returns _("Exit code: %(returncode)d; ...") [2].
Under non-English locales (we checked for Japanese, but surely this will
also occur in others, the check 'Exit code: 1' in str(e)  [3] will fail
since 'Exit code: 1' is not encoded the same.

This ultimately prevents stuff like booting a new VM.

[1]: http://pastebin.com/x66aqctN
[2]: https://github.com/openstack/neutron/blob/15d65607a47810f7d155d43902d358cb9f953a7a/neutron/agent/linux/utils.py#L127
[3]: https://github.com/openstack/neutron/blob/15d65607a47810f7d155d43902d358cb9f953a7a/neutron/agent/linux/utils.py#L176

** Affects: neutron
     Importance: Critical
     Assignee: John Schwarz (jschwarz)
         Status: Confirmed


** Tags: mitaka-backport-potential newton-backport-potential

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1638273

Title:
  find_child_pids crashes under non-english locals

Status in neutron:
  Confirmed

Bug description:
  Traceback available at [1].

  The function execute() returns _("Exit code: %(returncode)d; ...")
  [2]. Under non-English locales (we checked for Japanese, but surely
  this will also occur in others, the check 'Exit code: 1' in str(e)
  [3] will fail since 'Exit code: 1' is not encoded the same.

  This ultimately prevents stuff like booting a new VM.

  [1]: http://pastebin.com/x66aqctN
  [2]: https://github.com/openstack/neutron/blob/15d65607a47810f7d155d43902d358cb9f953a7a/neutron/agent/linux/utils.py#L127
  [3]: https://github.com/openstack/neutron/blob/15d65607a47810f7d155d43902d358cb9f953a7a/neutron/agent/linux/utils.py#L176

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1638273/+subscriptions


Follow ups