yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

This failed on an unrelated change today:

http://logs.openstack.org/24/394524/1/check/gate-nova-tox-db-functional-
ubuntu-xenial/01a5cce/console.html#_2016-11-07_17_27_14_569696

https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/tests/functional/notification_sample_tests/test_instance.py#L547

That says it expects 3 notifications, but it really only cares about 2.
Based on when the compute.exception happens, and when
self._wait_until_swap_volume_error() returns True, the 3rd
compute.exception notification might not have happened.

The swap_error flag is set in the cinder fixture here:

https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/tests/fixtures.py#L868

That happens here:

https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/compute/manager.py#L4936

Which is after the swap-volume error notification is sent.

The compute.exception comes from the instance fault handler here:

https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/compute/manager.py#L4961

Which is after cinder.swap_error is set to true.

** Affects: nova
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: functional notifications testing volume

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

** Changed in: nova
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1639894

Title:
  TestInstanceNotificationSample.test_volume_swap_server_with_error is
  racy

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  This failed on an unrelated change today:

  http://logs.openstack.org/24/394524/1/check/gate-nova-tox-db-
  functional-ubuntu-
  xenial/01a5cce/console.html#_2016-11-07_17_27_14_569696

  https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/tests/functional/notification_sample_tests/test_instance.py#L547

  That says it expects 3 notifications, but it really only cares about
  2. Based on when the compute.exception happens, and when
  self._wait_until_swap_volume_error() returns True, the 3rd
  compute.exception notification might not have happened.

  The swap_error flag is set in the cinder fixture here:

  https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/tests/fixtures.py#L868

  That happens here:

  https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/compute/manager.py#L4936

  Which is after the swap-volume error notification is sent.

  The compute.exception comes from the instance fault handler here:

  https://github.com/openstack/nova/blob/0132cc8c2663843a891e054d9185e6ba2fd589ad/nova/compute/manager.py#L4961

  Which is after cinder.swap_error is set to true.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1639894/+subscriptions