yahoo-eng-team team mailing list archive

[OpenStack Infra <1636109@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/393669
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b351ef5356e0472aef51221ff02376dd8b42954
Submitter: Jenkins
Branch:    master

commit 1b351ef5356e0472aef51221ff02376dd8b42954
Author: Esha Seth <eshaseth@xxxxxxxxxx>
Date:   Fri Nov 4 05:48:32 2016 -0400

    Add a no-op wait method to NetworkInfo
    
    The normal deploy flow uses a NetworkInfoAsyncWrapper for network
    allocation, and because of that many places have to call that class's
    wait method to make sure it has completed. During a reschedule where
    the network was allocated by a previous build attempt, a NetworkInfo
    instance is retrieved instead, which does not have a wait method. This
    then results in an exception complaining the missing method when it is
    called. This fix addresses that by adding a no-op wait method to the
    NetworkInfo class. Alternatively could have used isinstance or hasattr
    to avoid making wait calls on NetworkInfo, but that could be
    problematic to maintain as more places need to make wait calls in the
    future and may not know to make the isinstance/hasattr check.
    
    This fixes a regression issue caused by
    61fc1b9ee11e416aecbf3a29e1d150a53fc890e8 ,
    which reverted the previous fix made under
    24a04c405ab2c98e52ea1edf8775489907526c6d
    
    Change-Id: Id7a71b2eb46ea7df19e7da0afbc0eafa87cac965
    Closes-Bug: 1636109


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1636109

Title:
  Reschedule of a virtual machine fails with  'NetworkInfo' object has
  no 'wait'

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  Confirmed

Bug description:
  When a virtual machine is rescheduled and fails eith some storage exception, getting an error that
  'NetworkInfo' object has no attribute 'wait' instead of actual storage issue

  In nova/compute/manager

  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2088
  is actually throwing above exception because , network_info is a
  'NetworkInfoAsyncWrapper' object in first time deploy case and
  'NetworkInfo' object in a reschedule case, so during reschedule it is
  throwing 'wait' attribute is not there.

   def _build_networks_for_instance(self, context, instance,
              requested_networks, security_groups):

          # If we're here from a reschedule the network may already be allocated.
          if strutils.bool_from_string(
                  instance.system_metadata.get('network_allocated', 'False')):
              # NOTE(alex_xu): The network_allocated is True means the network
              # resource already allocated at previous scheduling, and the
              # network setup is cleanup at previous. After rescheduling, the
              # network resource need setup on the new host.
              self.network_api.setup_instance_network_on_host(
                  context, instance, instance.host)
              return self.network_api.get_instance_nw_info(context, instance)   --------  this block gets called for reschedule case which returns NetworkInfo object

          if not self.is_neutron_security_groups:
              security_groups = []

          macs = self.driver.macs_for_instance(instance)
          dhcp_options = self.driver.dhcp_options_for_instance(instance)
          network_info = self._allocate_network(context, instance,
                  requested_networks, macs, security_groups, dhcp_options)  ----------------- this block is called for deploy on first host which returns NetworkInfoAsyncWrapper which has wait.

          return network_info

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1636109/+subscriptions