yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #58574
[Bug 1638606] Re: api-ref: create keypair response is confusing wrt user_id and microversion 2.10
Reviewed: https://review.openstack.org/392845
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=be11fab555a5381ed179b136264ebe2c04859848
Submitter: Jenkins
Branch: master
commit be11fab555a5381ed179b136264ebe2c04859848
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date: Wed Nov 2 11:48:05 2016 -0400
api-ref: remove user_id from keypair list response and fix 2.10
The user_id has always been returned for the keypair create and
show operations. The user_id has never been returned in the list
response. The docs were a bit confusing for create and show since
they said 'New in version 2.10' for the user_id description in the
response.
This change clarifies the response docs so that we don't make it
sound like user_id is only getting returned for create/show with
microversion 2.10 and removes user_id from the response docs for
the list operation.
Change-Id: I4bd06c8ed88e526f44bb0d6e927c09175bf103b1
Closes-Bug: #1638606
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1638606
Title:
api-ref: create keypair response is confusing wrt user_id and
microversion 2.10
Status in OpenStack Compute (nova):
Fix Released
Bug description:
This is the api-ref doc on the create keypair response;
http://developer.openstack.org/api-ref/compute/?expanded=list-volume-
attachments-for-an-instance-detail,create-or-import-keypair-
detail#id210
The user_id description in the response is confusing since it says
'New in version 2.10'. In v2.1 the user_id is required in the response
per Tempest:
https://github.com/openstack/tempest/blob/13.0.0/tempest/lib/api_schema/response/compute/v2_1/keypairs.py#L66
And the code:
https://github.com/openstack/nova/blob/14.0.1/nova/api/openstack/compute/keypairs.py#L138
So we should update the docs a bit to not mention version 2.10 in the
user_id description for the keypair response.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1638606/+subscriptions
References