yahoo-eng-team team mailing list archive

[OpenStack Infra <1634115@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/387674
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f87af91d90f8f1322e92f9bc4d198a83162bb118
Submitter: Jenkins
Branch:    master

commit f87af91d90f8f1322e92f9bc4d198a83162bb118
Author: Pushkar Umaranikar <pushkar.umaranikar@xxxxxxxxx>
Date:   Mon Oct 17 20:42:43 2016 +0000

    Placement api: 404 response do not indicate what was not found
    
    Add informative messages to the 404 error response from
    nova/objects/resource_provider.py
    
    For the method _update_inventory_in_db() from resource_provider.py,
    gabbi test validation is not added since it is not being used and
    from the placement API you create an inventory but then call
    set_inventory or add_inventory on a resource_provider.
    
    Similar change, i.e. adding informative messages to 404 error can be
    done for api tests from inventory.yaml and usage.yaml
    
    It includes adding informative logging in code for 404 exceptions and
    adding gabbi tests for those.
    This can be done in follow up patch.
    
    Change-Id: If53f84ac5f7521e9926b97bdcce3cf77ec5b4ffd
    Closes-Bug: #1634115


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1634115

Title:
  in placement api, 404 response do not indicate what was not found

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In Placement api v1.0 some 404 response codes are directly the result
  of NotFound exception being raised from nova.objects.resource_provider
  without a message. This leads to the 404 response not including any
  indication of what was not found (other than the URL). This can be
  made more friendly and informative.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1634115/+subscriptions