← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1435908] Re: Refactor horizon.js

 

Reviewed:  https://review.openstack.org/341864
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9841990f1c5e206f5e05eb59671d361c95901ecf
Submitter: Jenkins
Branch:    master

commit 9841990f1c5e206f5e05eb59671d361c95901ecf
Author: Ernest Millan <millan@xxxxxxxxx>
Date:   Tue May 24 13:04:10 2016 -0700

    Create common code for horizon.instances.js and horizon.firewalls.js
    
    A majority of the previously duplicated code within the above mentioned
    files will now reference common-code within horizon.lists.js instead.
    
    Change-Id: Ica397697db33422fb5393c0088d0a695c3c15002
    Closes-bug: #1435908


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1435908

Title:
  Refactor horizon.js

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There are currently two instance of the same code being used in the
  horizon.js files for the instance launch and also the firewall
  policies (and soon to be third with firewall routers).

  Given all three are essentially using the same code - it makes sense
  to refactor this file so that all three features can make use of one
  common section of code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1435908/+subscriptions


References