yahoo-eng-team team mailing list archive

[OpenStack Infra <1629816@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/381025
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2f7c58f405288d323722ec6be224c4c70ccea8b3
Submitter: Jenkins
Branch:    master

commit 2f7c58f405288d323722ec6be224c4c70ccea8b3
Author: Oleg Bondarev <obondarev@xxxxxxxxxxxx>
Date:   Mon Oct 3 12:53:18 2016 +0300

    DVR: remove misleading error log
    
    csnat_ofport is always OFPORT_INVALID on compute nodes
    so the error was always wrong.
    Not sure how it could mean duplicate dvr port even on controllers,
    so the patch is just removing the condition and the log.
    
    Closes-Bug: #1629816
    Change-Id: Ifbb8128fbd932946dab84a73b780da495f2ea1af


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1629816

Title:
  Misleading "DVR: Duplicate DVR router interface detected for subnet"

Status in neutron:
  Fix Released

Bug description:
  The error message is seen on each ovs agent resync on compute node
  where there are dvr serviced ports. Resync can be triggered by any
  error - this is unrelated to this bug.

  The error message appears on processing distributed router port for a
  subnet which is already in local_dvr_map of the agent, see
  _bind_distributed_router_interface_port in ovs_dvr_neutron_agent.py:

   if subnet_uuid in self.local_dvr_map:
       ldm = self.local_dvr_map[subnet_uuid]
       csnat_ofport = ldm.get_csnat_ofport()
       if csnat_ofport == constants.OFPORT_INVALID:
           LOG.error(_LE("DVR: Duplicate DVR router interface detected "
                         "for subnet %s"), subnet_uuid)
           return

  where csnat_ofport = OFPORT_INVALID by default and can only change
  when the agent processes csnat port of the router - this will never
  happen on compute node and we'll see the misleading log.

  The proposal would be to delete the condition and the log as they're
  useless.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1629816/+subscriptions