yahoo-eng-team team mailing list archive

[OpenStack Infra <1606462@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/395956
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7db68e32023162d843d287a121fec64a6786e87c
Submitter: Jenkins
Branch:    master

commit 7db68e32023162d843d287a121fec64a6786e87c
Author: IWAMOTO Toshihiro <iwamoto@xxxxxxxxxxxxx>
Date:   Thu Nov 10 14:27:18 2016 +0900

    ovsfw: small cleanups to improve readability
    
    security_group_updated is actually called but of no use for ovsfw.
    Fix the comment to reflect the reality.  In iptables_firewall, the
    method is used to clear obsolete conntrack entries, but ovsfw implements
    that differently.  Also, remove empty definition of apply_port_filter,
    which is never called.
    
    Change-Id: I26b402e0fa5ac19022e022bf7c51e171d0f5d333
    Closes-Bug: #1606462


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1606462

Title:
  OVS firewall should make use of security_group_updated

Status in neutron:
  Fix Released

Bug description:
  Look at this:

  class OVSFirewallDriver(firewall.FirewallDriver):
  ...
      def security_group_updated(self, action_type, sec_group_ids,
                                 device_ids=None):
          """This method is obsolete

          The current driver only supports enhanced rpc calls into security group
          agent. This method is never called from that place.
          """

  but this is used by the enhanced rpc. See
  SecurityGroupAgentRpc._security_group_updated.

  Also this can be checked by inserting a test raise statement into the
  above method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1606462/+subscriptions