yahoo-eng-team team mailing list archive

[Radomir Dopieralski <1645721@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

We are using gettext inside the local_settings.py file, and I think we
shouldn't be doing that.

>From what I can see, there are basically two use cases:


Default values for labels
-------------------------

Those should probably be set inside settings.py, and local_settings.py
should only give an option to override them into non-translated strings.
We can't translate user-provided strings anyways, because we don't know
them up front.

Example values in commented code
--------------------------------

Those should probably not be translated -- the user will translate them when setting to their own values anyways. They are not translated anyways, as they are commented out, and so the translation
system doesn't pick them up.

** Affects: horizon
     Importance: Undecided
     Assignee: Radomir Dopieralski (thesheep)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Radomir Dopieralski (thesheep)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1645721

Title:
  Gettext inside settings

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  We are using gettext inside the local_settings.py file, and I think we
  shouldn't be doing that.

  From what I can see, there are basically two use cases:

  
  Default values for labels
  -------------------------

  Those should probably be set inside settings.py, and local_settings.py
  should only give an option to override them into non-translated
  strings. We can't translate user-provided strings anyways, because we
  don't know them up front.

  Example values in commented code
  --------------------------------

  Those should probably not be translated -- the user will translate them when setting to their own values anyways. They are not translated anyways, as they are commented out, and so the translation
  system doesn't pick them up.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1645721/+subscriptions