yahoo-eng-team team mailing list archive

[OpenStack Infra <1643013@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/399786
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=43e9df85ab286ddee96e9cff97f551781baf70d1
Submitter: Jenkins
Branch:    master

commit 43e9df85ab286ddee96e9cff97f551781baf70d1
Author: David Lyle <david.lyle@xxxxxxxxx>
Date:   Fri Nov 18 15:02:20 2016 -0700

    Rework hardcoded policy in admin dash
    
    Since the content in a Dashboard is not hardcoded, having hardcoded
    policy checks to specific services at the dashboard level is wrong.
    The Dashboard was designed to evaluate all panels to determine policy
    so this type of thing could be avoided. This patch moves the content
    specific policy checks to the panels where they apply.
    
    Additionally, this fix uncovered another bug where policy_rules are
    wrapped in a list regardless of format. This patch adds a check and
    only wraps where necessary.
    
    Change-Id: I79314a45c3c552ebcb3bb7cc881c2467fa009c5d
    Closes-Bug: #1643013
    Closes-Bug: #1643074


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1643013

Title:
  admin dashboard policy check wrong

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The addition of all the hardcoded policy rules in dashboards/admin/dashboard.py is unnecessary and actually wrong because it imposes policy based on content for panels that may be disabled. The functionality is actually already built in and designed to be dynamic, see: https://github.com/openstack/horizon/blob/master/horizon/base.py#L648
  where the panels are iterated over to check for policy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1643013/+subscriptions