yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #59668
[Bug 1296414] Re: quotas not updated when periodic tasks or startup finish deletes
The master patch seems to have merged
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1296414
Title:
quotas not updated when periodic tasks or startup finish deletes
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) juno series:
Fix Released
Status in OpenStack Compute (nova) kilo series:
Fix Released
Bug description:
There are a couple of cases in the compute manager where we don't pass
reservations to _delete_instance(). For example, one of them is
cleaning up when we see a delete that is stuck in DELETING.
The only place we ever update quotas as part of delete should be when
the instance DB record is removed. If something is stuck in DELETING,
it means that the quota was not updated. We should make sure we're
always updating the quota when the instance DB record is removed.
Soft delete kinda throws a wrench in this, though, because I think you
want soft deleted instances to not count against quotas -- yet their
DB records will still exist. In this case, it seems we may have a race
condition in _delete_instance() -> _complete_deletion() where if the
instance somehow was SOFT_DELETED, quotas would have updated twice
(once in soft_delete and once in _complete_deletion).
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1296414/+subscriptions
References