yahoo-eng-team team mailing list archive

[OpenStack Infra <1614537@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/393150
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bb78621a72bb0f54205fac57e19d4679143bc3f3
Submitter: Jenkins
Branch:    master

commit bb78621a72bb0f54205fac57e19d4679143bc3f3
Author: Zainub Wahid <zainub.wahid@xxxxxxxxxxxxxx>
Date:   Thu Nov 3 12:57:25 2016 +0500

    Make UUIDField actually validate UUIDs
    
    Instead of using oslo.versionedobjects UUID type, use a custom UUIDField
    class located in common_types that will actually validate passed values
    for UUID-ness.
    
    Closes-Bug: #1614537
    Change-Id: I20b24ee57c521b1c68977c2ff7ae56b56875dd64


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1614537

Title:
  Neutron Objects do not override the UUIDField to actually validate
  UUIDs

Status in neutron:
  Fix Released

Bug description:
  Oslo Versioned Objects' implementation of the UUID Field does not
  actually validate anything.

  It is a wrapper around a string type.

  Projects are advised that to actually validate UUIDs, they need to
  override the field in their custom fields. [1]

  Leaving it non validating can cause issues when the field is moved to
  validate, or there is an assumption that it is being validated.

  1 -
  http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1614537/+subscriptions