yahoo-eng-team team mailing list archive

[OpenStack Infra <1649403@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/409984
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5d3ae79455d1e601a1a718a274796a2354bf31e8
Submitter: Jenkins
Branch:    master

commit 5d3ae79455d1e601a1a718a274796a2354bf31e8
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date:   Mon Dec 12 19:17:49 2016 -0500

    Make test_create_delete_server_with_instance_update deterministic
    
    We're seeing race failures in this test because the ip_addresses
    can show up in an unexpected notification depending on when
    allocate_for_instance in the neutron network API completes and
    the instance.info_cache.network_info data gets stored in the
    database.
    
    We can resolve the race by using SpawnIsSynchronousFixture which
    makes the allocate_for_instance network API a blocking call
    until the network_info is returned, and by that time it's stored
    in the instance_info_cache in the database which is where the
    versioned notification pulls it from in _send_versioned_instance_update.
    
    Change-Id: Id482220b8332549a07efb4f82212d74e6e7b9d6c
    Closes-Bug: #1649403


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1649403

Title:
  nova.tests.functional.notification_sample_tests.test_instance.TestInstanceNotificationSample.test_create_delete_server_with_instance_update
  randomly fails with ip_addresses not set in notifications

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Seen here:

  http://logs.openstack.org/90/409890/1/check/gate-nova-tox-db-
  functional-ubuntu-
  xenial/17015ce/console.html#_2016-12-12_19_24_33_892626

  The differences between the expected notifications on instance.update
  notifications and what we actually get is the u'ip_addresses': [] is
  empty in the actual results. There is probably a race where the fake
  virt driver isn't waiting for the network allocation (which is stubbed
  out) to complete.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1649403/+subscriptions