yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #59776
[Bug 1608842] Re: [api-ref] The 'id' parameters are defined as 'optional' in os-volume_attachments
Reviewed: https://review.openstack.org/349863
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6ab20bc52392ea3eb4dcc1573fc842558eeb889e
Submitter: Jenkins
Branch: master
commit 6ab20bc52392ea3eb4dcc1573fc842558eeb889e
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date: Tue Aug 2 17:19:15 2016 +0900
api-ref: Fix 'id' (attachment_id) parameters
At first, the 'attachment_id_resp' in parameters.yaml was defined
as 'required' in I3789a4ad36e30728024f2aa122403b0e53b1e741
for os-volume_attachments.inc.
Then it was changed to 'optional' in
I0c1d183c5aaf6fb796be30fa5627bd5644ea689f
for os-volumes.inc.
So currently 'id' (attachment_id) parameters in
os-volume_attachments.inc are wrong.
They should be 'required'. So fix them.
Change-Id: I403a9eb1b08a840cbb2b82cb37f1b49c6edb87c9
Closes-Bug: #1608842
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1608842
Title:
[api-ref] The 'id' parameters are defined as 'optional' in os-
volume_attachments
Status in OpenStack Compute (nova):
Fix Released
Bug description:
http://developer.openstack.org/api-ref/compute/?expanded=#servers-
with-volume-attachments-servers-os-volume-attachments
In os-volume_attachments of api-ref, the 'id' (attachement ID) parameters are defined as 'optional'.
But they are not optional actually.
https://github.com/openstack/nova/blob/9fdb5a43f2d2853f67e28ed33a713c92c99e6869/nova/api/openstack/compute/volumes.py#L225
https://github.com/openstack/nova/blob/9fdb5a43f2d2853f67e28ed33a713c92c99e6869/nova/api/openstack/compute/volumes.py#L339
Originally they are defined as 'required'.
But it was changed by the following patch.
https://review.openstack.org/#/c/320048/
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1608842/+subscriptions
References