yahoo-eng-team team mailing list archive

[OpenStack Infra <1643181@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/399860
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9abcf5a7fefd1c6e65b11c0c72b24a6ac2e527f1
Submitter: Jenkins
Branch:    master

commit 9abcf5a7fefd1c6e65b11c0c72b24a6ac2e527f1
Author: int32bit <krystism@xxxxxxxxx>
Date:   Sat Nov 19 21:44:18 2016 +0800

    [test]Change fake image info to fit instance xml
    
    In our libvirt driver unit tests, both the image path and the file
    format are not consistent with our fake instance xml. Though these
    won't break out our work, it's really a little misleading.
    
    Change-Id: I6d5e01fafaecee45b4d4736c75714a45032990a3
    Closes-Bug: #1643181


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1643181

Title:
  instance xml not consistent with image info

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In our unit tests, both `test_get_instance_disk_info_works_correctly`
  and `test_get_instance_disk_info_excludes_volumes` in
  `virt/libvirt/test_driver.py` dummy xml are as follows:

  dummyxml = ("<domain type='kvm'><name>instance-0000000a</name>"
                      "<devices>"
                      "<disk type='file'><driver name='qemu' type='raw'/>"
                      "<source file='/test/disk'/>"
                      "<target dev='vda' bus='virtio'/></disk>"
                      "<disk type='file'><driver name='qemu' type='qcow2'/>"
                      "<source file='/test/disk.local'/>"
                      "<target dev='vdb' bus='virtio'/></disk>"
                      "</devices></domain>")

  But the mock image info:

  ret = ("image: /test/disk\n"
                 "file format: raw\n"
                 "virtual size: 20G (21474836480 bytes)\n"
                 "disk size: 3.1G\n"
                 "cluster_size: 2097152\n"
                 "backing file: /test/dummy (actual path: /backing/file)\n")

  The image path(disk vs disk.local) and the file format(raw vs qcow2)
  are not consistent with our define before. Though these won't break
  out our work, it's really a little misleading.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1643181/+subscriptions