← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1649665] Re: Erroneous limit parameter not included in error message for neutron port-list --limit

 

Reviewed:  https://review.openstack.org/410375
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e45d2a904d76e840a55b15d8f94a548a35e5969b
Submitter: Jenkins
Branch:    master

commit e45d2a904d76e840a55b15d8f94a548a35e5969b
Author: Brian Haley <brian.haley@xxxxxxx>
Date:   Tue Dec 13 14:35:26 2016 -0500

    Correctly print --limit value passed via API
    
    Passing an invalid limit value, for example '--limit -1'
    in neutronclient, generates this error from the API:
    
      Bad limit request: Limit must be an integer 0 or
      greater and not '%d'.
    
    It should print what was passed.
    
    Closes-bug: #1649665
    
    Change-Id: I9b8bd67d344cd91e008f7c897f1ea6a020a9c30b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1649665

Title:
  Erroneous limit parameter not included in error message for neutron
  port-list --limit

Status in neutron:
  Fix Released

Bug description:
  Running a "previously happy on Mitaka" cleanup script which included
  a:

  neutron port-list --all-tenants --limit -1

  command now returns an error under Newton:

  stack@np-cp1-c0-m1-mgmt:~/rjones2$ neutron port-list --all-tenants --limit -1
  Bad limit request: Limit must be an integer 0 or greater and not '%d'.
  Neutron server returns request_ids: ['req-27f59b03-d063-4bd2-a84f-43a6545c1f41']

  Independent of whether the command should still accept a -1, it would
  seem the error message is in error - the percent-d should be the value
  provided to the --limit option.  Looking at
  https://github.com/openstack/neutron/blob/master/neutron/api/api_common.py
  one can see that "limit" is not added to msg in _get_limit_param.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1649665/+subscriptions


References