yahoo-eng-team team mailing list archive

[Steve Martinelli <1652458@xxxxxxxxxxxxxxxxxx>]

** Also affects: keystone
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1652458

Title:
  Tests unnecessarily use pep8 internals, don't work with pycodestyle

Status in OpenStack Identity (keystone):
  New
Status in python-keystoneclient:
  New

Bug description:
  test_hacking_checks.py isn't aware of the pep8 library being renamed
  pycodestyle; it's trivial to have it work with either name.

  The test also uses a rather unnecessarily baroque method to run only
  the K333 check; it's really not necessary to mock patch pep8's
  internals to do this, you can use its public API just as well.

  Here's a patch which fixes both issues. I'm really not interested in
  jumping through fifteen thousand hoops and signing my firstborn over
  to the openstack foundation just to submit some patches I wrote in the
  course of distro package fixing. I work for Red Hat, which is (I
  believe) a corporate member of the the foundation, so I don't even
  know if it's appropriate/allowed for me to sign up as a personal
  member.

  If it helps, I'm happy to declare this patch available under a very
  permissive license like CC-0, or just sign it over to a contributor,
  for the purpose of getting it merged.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1652458/+subscriptions