yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #60182
[Bug 1653472] Re: remove the CONF.domain_id_immutable option
Reviewed: https://review.openstack.org/416267
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=663865dfecb483f0ef6aa48749c0712779033dd7
Submitter: Jenkins
Branch: master
commit 663865dfecb483f0ef6aa48749c0712779033dd7
Author: Lance Bragstad <lbragstad@xxxxxxxxx>
Date: Tue Jan 3 15:11:12 2017 +0000
Remove CONF.domain_id_immutable
We deprecated this functionality during the Mitaka release and staged
it for removal in Ocata. Let's remove it!
A note for reviewers. Some of the logic for allowing projects to
update their domain_id was implemented in the resource Manager().
As a result, there were several tests that tested the manager
directly. Now that we're removing the logic for allowing
``domain_id`` to be update, we can rely solely on the
``_require_matching_domain_id()`` method in the
keystone.common.controller module. This short-circuit check will
return a 4XX response code for all requests attempting to update the
``domain_id`` of an entity. Since this is all completely isolated
in the controller layer, we can remove the logic from the resource
Manager specifically as well as the tests. This change looks like
we're removing a bunch of tests from
keystone.tests.unit.resource.test_backends but we're actually just
relying on more basic tests in test_v3_resource.
Change-Id: Iad0eba66e7ddc9497205af60671451a385d0de58
Closes-Bug: 1653472
** Changed in: keystone
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1653472
Title:
remove the CONF.domain_id_immutable option
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
The option was deprecated in Mitaka and can be removed in Ocata or
newer:
https://github.com/openstack/keystone/blob/7871fbcab1d86604e258151a660fed1edc9ae501/keystone/conf/default.py#L150-L163
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1653472/+subscriptions
References