yahoo-eng-team team mailing list archive

[OpenStack Infra <1653960@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/416552
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=83e3ff88ec2f3b776c282bdb73fdf23cb2ab3468
Submitter: Jenkins
Branch:    master

commit 83e3ff88ec2f3b776c282bdb73fdf23cb2ab3468
Author: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
Date:   Wed Jan 4 13:31:36 2017 +0000

    Remove duplicated modal_header statements
    
    Across the codebase we've been using modal_header values that are
    identical (or very close to) the page_title values. This patch sets the
    modal_header to default to the page_title value, and cleans up a few
    inconsistencies. Also deleted a couple of redundant submit_label values
    that were identical to the default ("Submit").
    
    Change-Id: I88815c3801c29b3fbc41e0cb426a50653255595f
    Closes-Bug: 1653960


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1653960

Title:
  Modal header should default to page_header

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Many modals have a modal_header value that is identical to
  page_header; we could just default to page_header and remove the
  duplication.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1653960/+subscriptions