← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1563874] Re: libvirt: Snapshot and resume does not work for instances with some SR-IOV ports

 

Reviewed:  https://review.openstack.org/300890
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b691125b621c781c89f15b421215ebad5085c4d0
Submitter: Jenkins
Branch:    master

commit b691125b621c781c89f15b421215ebad5085c4d0
Author: Moshe Levi <moshele@xxxxxxxxxxxx>
Date:   Sun Apr 3 19:11:07 2016 +0300

    pci: Clarify SR-IOV ports vs direct passthrough ports
    
    This patch clarify for what type of ports
    detach/attach pci device is needed and for what type of
    port we just need pci request. To avoid confusion this
    patch introduce 2 type of ports list VNIC_TYPES_SRIOV
    and VNIC_TYPES_DIRECT_PASSTHROUGH. The VNIC_TYPES_SRIOV
    are ports which require pci request, while
    VNIC_TYPES_DIRECT_PASSTHROUGH  ports require pci device
    attach/detach from libvirt dom. VNIC_TYPES_DIRECT_PASSTHROUGH
    is subset of VNIC_TYPES_SRIOV.
    
    Closes-Bug: #1563874
    
    Change-Id: I3a45b1fb41e8e446d1f25d7a1d77991c8bf2a1ed


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1563874

Title:
  libvirt: Snapshot and resume does not work for instances with some SR-
  IOV ports

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  libvirt driver methods that are used for determining whether a port is
  an SR-IOV port do not check properly for all possible SR-IOV port
  types:

  https://github.com/openstack/nova/blob/f15d9a9693b19393fcde84cf4bc6f044d39ffdca/nova/virt/libvirt/driver.py#L3378

  should be checking for VNIC_TYPES_SRIOV instead.

  This affects snapshot and suspend/resume functionality provided by the
  libvirt driver, for instances using non-direct flavors of SR-IOV

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1563874/+subscriptions


References