← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1654659] Re: test_sql_upgrade docstring needs update

 

Reviewed:  https://review.openstack.org/417647
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d42bb2da670022cfdfc00900f8da27421d26af67
Submitter: Jenkins
Branch:    master

commit d42bb2da670022cfdfc00900f8da27421d26af67
Author: Tin Lam <tinlam@xxxxxxxxx>
Date:   Sat Jan 7 22:46:05 2017 -0600

    Updated docstring for test_sql_upgrade.py
    
    The docstring at [1] references usage of backend_sql.conf, which is no
    longer used by the tests.  The tests are using oslo.db unit tests base.
    This patchset updates the docstring and places a reference to [2].
    
    [1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L14-L32
    [2] http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests
    
    Change-Id: Ifc3cb8c2a57c83a44408be5771a88f141d6b31e5
    Closes-Bug: #1654659


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1654659

Title:
  test_sql_upgrade docstring needs update

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Currently, the docstring at [1] states the usage of the
  backend_sql.conf file, which isn't used anymore in the tests of the
  module. Instead, the tests are using oslo.db unit tests base [2]. This
  doesn't mean the backend_sql.conf file isn't used anywhere else, but
  that it is not used anymore at test_sql_upgrade.

  [1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L14-L32
  [2] http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1654659/+subscriptions


References