← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1600418] Re: Flavor name edit should trim for white spaces and compare with other flavor names

 

Reviewed:  https://review.openstack.org/403687
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=23c482b941b53243b9f57c5707d266870c3c2225
Submitter: Jenkins
Branch:    master

commit 23c482b941b53243b9f57c5707d266870c3c2225
Author: Yakup Adakli <yakup.adakli@xxxxxxxxx>
Date:   Mon Nov 28 15:28:44 2016 +0300

    Strip whitespace added to flavor name in create and update flavor.
    
    Change-Id: I633a4124615ca0c6cfe6b103e117e3ebd6d79241
    Closes-Bug: #1600418


** Changed in: horizon
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1600418

Title:
  Flavor name edit should trim for white spaces and compare with other
  flavor names

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When editing the flavor name from horizon
  1. Enter new flavor name which is same as one of the existing flavor name
  2. Make sure that you have entered leading and trailing spaces
  Try saving this flavor and it fails with error.
  we should ideally strip the flavor name before making any comparison.

  As a specific example
  1. Create flavor with name test1
  2. Create flavor with name test2
  3. Edit flavor test2
  4. When editing try giving name "    test1    "(new name same as one of the existing flavor and leading and trailing spaces in the new name)
  5. Save the flavor
  6. we get an error that 'Unable to modify test1'.

  Now we were modifying test2 and not test1. Error should ideally say
  that the flavor with name 'test1' already exists(as the case is if we
  try the same from CLI)

  One more unexpected behavior that happens is that 'test2' in above
  case is removed from the flavor listing page in UI

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1600418/+subscriptions


References