yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

See the discussion in this review:

https://review.openstack.org/#/c/409890/1/nova/cmd/manage.py@1289

The map_cell0 CLI is really treated like a function and it's used by the
simple_cell_setup command. If map_cell0 is used as a standalone command
it always returns a non-0 exit code because it's returning a CellMapping
object (or failing with a duplicate entry error if the cell0 mapping
already exists).

We should split the main part of the map_cell0 function out into a
private method and then treat map_cell0 as a normal CLI with integer
exit codes (0 on success, >0 on failure) and print out whatever
information is needed when mapping cell0, like the uuid for example.

** Affects: nova
     Importance: Medium
         Status: Confirmed


** Tags: cells nova-manage

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1656017

Title:
  nova-manage cell_v2 map_cell0 always returns a non-0 exit code

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  See the discussion in this review:

  https://review.openstack.org/#/c/409890/1/nova/cmd/manage.py@1289

  The map_cell0 CLI is really treated like a function and it's used by
  the simple_cell_setup command. If map_cell0 is used as a standalone
  command it always returns a non-0 exit code because it's returning a
  CellMapping object (or failing with a duplicate entry error if the
  cell0 mapping already exists).

  We should split the main part of the map_cell0 function out into a
  private method and then treat map_cell0 as a normal CLI with integer
  exit codes (0 on success, >0 on failure) and print out whatever
  information is needed when mapping cell0, like the uuid for example.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1656017/+subscriptions