yahoo-eng-team team mailing list archive

[OpenStack Infra <1656051@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/422686
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a194157cd9e6cfcf03610c68b86e8bc34545c14d
Submitter: Jenkins
Branch:    master

commit a194157cd9e6cfcf03610c68b86e8bc34545c14d
Author: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
Date:   Thu Jan 19 15:12:30 2017 +0000

    Fix Angular tabs
    
    Change-Id: I0108e200d10f6bfc7e835f6c53d9e30abd4eafdf
    Closes-Bug: 1656051


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1656051

Title:
  Angular registry detailViews no longer display as tabs

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Dashboard (Horizon) ocata series:
  Fix Released
Status in OpenStack Search (Searchlight):
  New

Bug description:
  The angular registry allows you to create tabs dynamically by
  registering them [0][1].  This technique is used by the instances
  panel in the searchlight UI [2].  Sometime in Ocata it got broken and
  now tabs no longer show up in the instances panel in either default or
  material theme.

  https://imgur.com/a/JIO3Z

  [0]
  https://github.com/openstack/horizon/blob/2394397bfd258fe584cc565a924e4dd216f6b224/horizon/static/framework/conf
  /resource-type-registry.service.js#L84

  [1]
  https://github.com/openstack/horizon/blob/2925562c1a3f0a9b3e2d55833691a7b0ad10eb2a/horizon/static/framework/widgets/details/details.directive.js#L28-L61

  [2] https://github.com/openstack/searchlight-
  ui/blob/master/searchlight_ui/static/resources/os-nova-
  servers/details/details.module.js#L52-L72

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1656051/+subscriptions