yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #60761
[Bug 1653780] Re: Cyclic import issue with use of common_types
Reviewed: https://review.openstack.org/416352
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7d99bf0c8d575729eb5fe6ef1325a53eee23ed10
Submitter: Jenkins
Branch: master
commit 7d99bf0c8d575729eb5fe6ef1325a53eee23ed10
Author: Manjeet Singh Bhatia <manjeet.s.bhatia@xxxxxxxxx>
Date: Tue Jan 3 21:14:50 2017 +0000
Break circular import with use of common_types
Using UUIDFIelds from common types in objects/quota.py in [1],
ended up in circular imports. This patch will fix it.
[1]. https://review.openstack.org/#/c/338625/
Change-Id: I67580a875d2a8c8a791b9e246c1247349c4771df
Closes-Bug: #1653780
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1653780
Title:
Cyclic import issue with use of common_types
Status in neutron:
Fix Released
Bug description:
We have defined some custom types in neutron/object/common_types
to better control and validate the input, but use of common_types in
objects/quota.py will lead to cyclic import like this
neutron.api.v2.base -> neutron.quota -> neutron.db.quota.api ->
neutron.objects.quota -> neutron.objects.common_types ->
neutron.extensions.dns -> neutron.extensions.l3 ->
neutron.api.v2.resource_helper) (cyclic-import)
this is required to break for quota_ovo patch
https://review.openstack.org/#/c/338625/
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1653780/+subscriptions
References