← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1655610] Re: alembic_version table has no primary key

 

Reviewed:  https://review.openstack.org/419320
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc075fa0d83bbd2a4c7b46299a35ccedb91388dc
Submitter: Jenkins
Branch:    master

commit fc075fa0d83bbd2a4c7b46299a35ccedb91388dc
Author: Ann <akamyshnikova@xxxxxxxxxxxx>
Date:   Thu Jan 12 08:12:50 2017 +0000

    Manually add pk for alembic_version table
    
    We hit a problem that Neutron migrations cannot be applied
    on galera cluster with ENFORCING mode as alembic_version table
    missing primary key on the table and it is expected that all tables
    will have primary keys.
    
    alembic_version is created and managed by Alembic and fixes for this
    on Alembic side are on the review [1]. Anyway here migration is
    proposed that will add pk on this table if it is missing, as in
    other case we will have inconsistency between new deployments and
    old ones.
    
    [1] - https://gerrit.sqlalchemy.org/#/c/279/
    
    Change-Id: I543a1ee286bdf11ae35adb87125d044a351a2648
    Closes-bug: #1655610


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1655610

Title:
  alembic_version table has no primary key

Status in neutron:
  Fix Released

Bug description:
  Currently alembic_version table in the neutron db has no primary key.

  Which is a bad thing, if you consider to use Galera as a database,
  since it requires primary keys in all tables.

  For example, during the "INFO  [alembic.runtime.migration] Running
  upgrade  -> kilo, kilo_initial" migration you will get the:

  oslo_db.exception.DBError: (pymysql.err.InternalError) (1105, u
  'Percona-XtraDB-Cluster prohibits use of DML command on a table
  (neutron.alembic_version) without an explicit primary key with
  pxc_strict_mode = ENFORCING or MASTER') [SQL: u"INSERT INTO
  alembic_version (version_num) VALUES ('kilo')"]

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1655610/+subscriptions


References