yahoo-eng-team team mailing list archive

[OpenStack Infra <1658817@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/424361
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=8a97921783cc4b7aae2b0c2fd764813fa0aa2821
Submitter: Jenkins
Branch:    master

commit 8a97921783cc4b7aae2b0c2fd764813fa0aa2821
Author: Cedric Brandily <zzelle@xxxxxxxxx>
Date:   Mon Jan 23 23:37:48 2017 +0100

    Optimize _make_firewall_dict_with_rules db queries
    
    This change optimizes _make_firewall_dict_with_rules implementation by
    getting rules for a firewall in one db query instead of one db query per
    rule (previous implementation). It improves performance: typically on
    my deployment _make_firewall_dict_with_rules for a firewall with 1000
    rules takes 0.2s instead of 12s with previous implementation.
    
    Change-Id: Ia5cd39ec4ee388fab21884d08e2b19f6f6c484d5
    Closes-Bug: #1658817


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1658817

Title:
  _make_firewall_dict_with_rules gets FW rules one by one from db

Status in neutron:
  Fix Released

Bug description:
  _make_firewall_dict_with_rules returns a firewall and its rules by
  calling get_firewall, get_firewall_policy and get_firewall_rule for
  each rule ... which implies a db query for each rule and slowness (on
  my deploiement 12s to get a firewall with 1000 rules).

  It seems possible to get all FW rules in one db query.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1658817/+subscriptions