yahoo-eng-team team mailing list archive

[Boden R <bodenvmw@xxxxxxxxx>]

Going to close this one out; it's more or less noise.
The change in [1] addresses the issue, but continue to discuss the best way to deal with hacking checks in lib. For example [2]. That said, I don't see a reason to leave this bug open; it's unnecessary.


[1] https://review.openstack.org/350723/
[2] https://review.openstack.org/421484/

** Changed in: neutron
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1609478

Title:
  neutron-lib hacking check roll-out breaks consumers

Status in neutron:
  Invalid

Bug description:
  Since [1] merged, the periodic-neutron-py34-with-neutron-lib-master
  job is failing with:

  
  2016-08-03 06:12:19.091524 | --- import errors Non-zero exit code (2) from test listing.
  2016-08-03 06:12:19.091836 | ---
  2016-08-03 06:12:19.093990 | Failed to call load_tests:
  2016-08-03 06:12:19.096585 | Traceback (most recent call last):
  2016-08-03 06:12:19.110744 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/.tox/py34-neutron-lib-master/lib/python3.4/site-packages/unittest2/loader.py", line 147, in loadTestsFromModule
  2016-08-03 06:12:19.114036 |     return load_tests(self, tests, pattern)
  2016-08-03 06:12:19.124972 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/neutron/tests/unit/hacking/test_checks.py", line 399, in load_tests
  2016-08-03 06:12:19.126979 |     ignore=('F', 'H104'))
  2016-08-03 06:12:19.140594 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/.tox/py34-neutron-lib-master/lib/python3.4/site-packages/flake8/engine.py", line 234, in get_style_guide
  2016-08-03 06:12:19.143540 |     styleguide = StyleGuide(**kwargs)
  2016-08-03 06:12:19.156669 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/.tox/py34-neutron-lib-master/lib/python3.4/site-packages/flake8/engine.py", line 154, in __init__
  2016-08-03 06:12:19.162183 |     self._styleguide = kwargs.pop('styleguide', NoQAStyleGuide(**kwargs))
  2016-08-03 06:12:19.169531 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/.tox/py34-neutron-lib-master/lib/python3.4/site-packages/pep8.py", line 1651, in __init__
  2016-08-03 06:12:19.169591 |     options.logical_checks = self.get_checks('logical_line')
  2016-08-03 06:12:19.169641 |   File "/home/jenkins/workspace/periodic-neutron-py34-with-neutron-lib-master/.tox/py34-neutron-lib-master/lib/python3.4/site-packages/pep8.py", line 1747, in get_checks
  2016-08-03 06:12:19.169654 |     return sorted(checks)
  2016-08-03 06:12:19.169673 | TypeError: unorderable types: function() < function()
  2016-08-03 06:12:19.169690 | The test run didn't actually run any tests


  See [2] for full log

  [1] https://review.openstack.org/#/c/333500/
  [2] http://logs.openstack.org/periodic/periodic-neutron-py34-with-neutron-lib-master/532d25b/console.html#_2016-08-03_06_12_19_093990

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1609478/+subscriptions