yahoo-eng-team team mailing list archive

[OpenStack Infra <1659342@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/425262
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=41ee8c0677b69f7d76092d76465d6f318e74c8b9
Submitter: Jenkins
Branch:    master

commit 41ee8c0677b69f7d76092d76465d6f318e74c8b9
Author: Gábor Antal <antal@xxxxxxxxxxxxxxx>
Date:   Wed Jan 25 16:36:48 2017 +0100

    Fix TypeError in api/neutron.py
    
    In api/neutron.py [1], there is a logging, which throws a TypeError,
    because the arguments of the format message is passed as a tuple,
    which is not working when you pass the arguments to the logger,
    instead of replacing in-place. In the current code, running the log
    message leds to the following:
    
    TypeError: not enough arguments for format string
    Call stack:
      File "test.py", line 9, in <module>
        "router=%s", (router_id, router))
    Message: 'router_static_route_list(): router_id=%s, router=%s'
    Arguments: (('asd', 'asdf'),)
    
    In this patchset, this bug is fixed.
    
    [1]: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L1079
    
    Change-Id: I233c435bb7ca89c6c8ecd49a66bccb5b59eedf41
    Closes-Bug: #1659342


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1659342

Title:
  TypeError in message logging

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In openstack_dashboard/api/neutron.py [1], There is a wrongly
  rewritten message logging, which trows TypeError instead of logging.
  This code was merged a long time ago [2].

  The lines are the following: 
          LOG.debug("router_static_route_list(): router_id=%s, "
                    "router=%s", (router_id, router))

  Which I think wanted to be the following:
          LOG.debug("router_static_route_list(): router_id=%s, "
                    "router=%s" % (router_id, router))

  But since there is a guideline to delay the string interpolation and leave it to the logger, it should be something like this (or add names, that would be more elegant): 
          LOG.debug("router_static_route_list(): router_id=%s, "
                    "router=%s", router_id, router)

  [1]: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L1079
  [2]: https://review.openstack.org/#/c/135890/

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1659342/+subscriptions