← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1651549] Re: fix spec file variable

 

Reviewed:  https://review.openstack.org/413208
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d4083d18ad78276aa99843f99d0dbc16d0d81266
Submitter: Jenkins
Branch:    master

commit d4083d18ad78276aa99843f99d0dbc16d0d81266
Author: Cindy Lu <clu@xxxxxxxxxx>
Date:   Tue Dec 20 10:32:59 2016 -0800

    Fix spec file variable/ improve code coverage
    
    - fix wrong deferred.resolve() assignment
    - static/app/core/images/details/ branch coverage
    used to be 50%
    - use angular.isArray() instead of $.isArray()
    
    Change-Id: Iad7a688513a2f71a779bb621b6046485cb62cc0d
    Closes-Bug: #1651549


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1651549

Title:
  fix spec file variable

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/details/overview.controller.spec.js#L33

  should be sessionDeferred.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1651549/+subscriptions


References