← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1658571] Re: Microversion 2.37 break 2.32 usage

 

Reviewed:  https://review.openstack.org/424759
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e80e2511cf825671a479053cc8d41463aab1caaa
Submitter: Jenkins
Branch:    master

commit e80e2511cf825671a479053cc8d41463aab1caaa
Author: Artom Lifshitz <alifshit@xxxxxxxxxx>
Date:   Tue Jan 24 12:27:15 2017 -0500

    Fix tag attribute disappearing in 2.33 and 2.37
    
    In the context of device tagging, bugs have caused the tag attribute
    to disappear starting with version 2.33 for block_devices and starting
    with version 2.37 for network interfaces. In other words, block
    devices could only be tagged in 2.32 and network interfaces between
    2.32 and 2.36 inclusively.
    
    This patch documents this behaviour in api-ref and introduces
    microversion 2.42, which re-adds the tag in all the right places.
    
    Change-Id: Ia0869dc6f7f5bd347ccbd0930d1d668d37695a22
    Closes-bug: 1658571
    Implements: blueprint fix-tag-attribute-disappearing


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1658571

Title:
  Microversion 2.37 break 2.32 usage

Status in OpenStack Compute (nova):
  Fix Released
Status in python-novaclient:
  New

Bug description:
  Device tagging support was added in microversion 2.32, as for
  ports:
  http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n76
  but in latter microversion 2.37 accidentally removed it:
  http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n82

  And for bdms:
  the schema is added by
  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/block_device_mapping.py#L76
  and it will only work for microversion 2.32

  So this function is only usable from microversion 2.32 to 2.37 for
  ports and only for 2.32 for bdms.

  we should fix it and backport to Newton.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1658571/+subscriptions


References