yahoo-eng-team team mailing list archive

[OpenStack Infra <1661195@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/428071
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cd29a4e6c5af419050f0db1a2d8cc2c45bdcde03
Submitter: Jenkins
Branch:    master

commit cd29a4e6c5af419050f0db1a2d8cc2c45bdcde03
Author: ghanshyam <ghanshyammann@xxxxxxxxx>
Date:   Thu Feb 2 10:02:53 2017 +0000

    Fix access_ip_v4/6 filters params for servers filter
    
    While adding the json schema for servers filter query,
    we added 'accessIPv4' and 'accessIPv6' as allowed params
    but they do not match with what DB has. It is 'access_ip_v4'
    and 'access_ip_v6' in DB.
    This makes  'access_ip_v4' and 'access_ip_v6' filter stop working.
    
    The schema should be fixed accordingly to allow the 'access_ip_v4'
    and 'access_ip_v6' as valid filter.
    
    'accessIPv4' and 'accessIPv6' are something the API accepts
    and returns and internally API layer translate those param
    to their respective field('access_ip_v4' and 'access_ip_v6')
    present in DB.
    So user does not know anything about 'access_ip_v4' and
    'access_ip_v6'. They are not in API representation actually.
    
    Later list filter and sort param should be same as field return
    in GET or accepted in POST/PUT which are 'accessIPv4' and 'accessIPv6'.
    But that is something new attribute support in filter and can be
    done later after more discussion.
    
    Change-Id: Idc12de0062d298259e25c8b4c0dde889054a9ae5
    Closes-Bug: #1661195


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1661195

Title:
  Servers filter by access_ip_v4 does not filter servers

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Recently we added the server list query param validation in json
  schema. In schema, 'accessIPv4' and 'accessIPv6' are allowed which
  does not match with what DB has. It is 'access_ip_v4' and
  'access_ip_v6' in DB.

  Below schema should be fixed accordingly to allow the 'access_ip_v4'
  and 'access_ip_v6' as valid filter.

  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L343-L344

  
  On other note:
  'accessIPv4' and 'accessIPv6' are the something API accept and return and internally API layer translate those param to their respective field('access_ip_v4' and 'access_ip_v6') present in DB.
  So user does not know anything about 'access_ip_v4' and 'access_ip_v6'. They are not in API representation actually. 

  List filter and sort param should be same as field return in GET or
  accepted in POST/PUT which are 'accessIPv4' and 'accessIPv6'. But that
  is something new attribute support in filter and can be done later
  after discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1661195/+subscriptions