yahoo-eng-team team mailing list archive

[OpenStack Infra <1659655@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/425924
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b6d9a3f0a3510530ea4de28937d6f8595068531a
Submitter: Jenkins
Branch:    master

commit b6d9a3f0a3510530ea4de28937d6f8595068531a
Author: Thomas Morin <thomas.morin@xxxxxxxxxx>
Date:   Thu Jan 26 22:08:56 2017 +0100

    Fix WaitTimeout string representations
    
    Since eventlet.TimeoutError constructor is not called,
    TimeoutError __str__and __repr__ are not usable.
    
    This change ensures that the methods from the Exception
    base class are used.
    
    Change-Id: I27f44006b080f4f10983a026597fa47127950609
    Closes-Bug: 1659655


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1659655

Title:
  test fails with a bogus message: 'WaitTimeout' object has no attribute
  'seconds'

Status in neutron:
  Fix Released

Bug description:
  On some timeouts, the following is seen in test logs (e.g. [1]):

    Traceback (most recent call last):
      File "neutron/tests/base.py", line 117, in func
        self.fail('Execution of this test timed out: %s' % e)
      File "/opt/stack/new/neutron/.tox/dsvm-functional/local/lib/python2.7/site-packages/eventlet/timeout.py", line 108, in __str__
        if self.seconds is None:
    AttributeError: 'WaitTimeout' object has no attribute 'seconds'

  
  This seems to be due to WaitTimeout inheriting from eventlet.timeout.Timeout but not using its constructor [2] which initiates self.seconds.

  [1] http://logs.openstack.org/56/425756/1/check/gate-neutron-dsvm-functional-ubuntu-xenial/c6bb644/console.html#_2017-01-26_15_57_28_297978
  [2] https://github.com/eventlet/eventlet/blob/master/eventlet/timeout.py#L51

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1659655/+subscriptions