← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1664334] Re: CONF.placement.os_interface is not used in nova-status upgrade check

 

Reviewed:  https://review.openstack.org/433257
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2c1e1341214356808936c4a812c89d4008cdb284
Submitter: Jenkins
Branch:    master

commit 2c1e1341214356808936c4a812c89d4008cdb284
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date:   Mon Feb 13 15:48:43 2017 -0500

    Cleanup some issues with CONF.placement.os_interface
    
    This change fixes a few things with the recently added
    "os_interface" option in the [placement] config group.
    
    1. It adds tests for the scheduler report client that
       were missing in the original change that added the
       config option.
    
    2. It uses the option in the "nova-status upgrade check"
       command so it is consistent with how the scheduler
       report client uses it.
    
    3. It removes the restrictive choices list from the
       config option definition. keystoneauth1 allows an
       "auth" value for the endpoint interface which means
       don't use the service catalog to find the endpoint
       but instead just read it from the "auth_url" config
       option. Also, the Keystone v3 API performs strict
       validation of the endpoint interface when creating
       an endpoint record. The list of supported interfaces
       may change over time, so we shouldn't encode that
       list within Nova.
    
    4. As part of removing the choices, the release note
       associated with the new option is updated and changed
       from a 'feature' release note to simply 'other' since
       it's not really a feature as much as it is a bug fix.
    
    Change-Id: Ia5af05cc4d8155349bab942280c83e7318749959
    Closes-Bug: #1664334


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1664334

Title:
  CONF.placement.os_interface is not used in nova-status upgrade check

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) ocata series:
  In Progress

Bug description:
  https://review.openstack.org/#/c/426163/ added the
  CONF.placement.os_interface option so that you can connect nova to the
  placement service on a non-public endpoint.

  However, that change was (1) missing unit tests and (2) didn't include
  using that option in the nova-status upgrade check code here:

  https://github.com/openstack/nova/blob/6eaf6dcb1e6382380d1c96d5b6fd3b3dc11fed2b/nova/cmd/status.py#L182

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1664334/+subscriptions


References