← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1658868] Re: Should raise retry limit exceed error instead of class exist in Placement API

 

Reviewed:  https://review.openstack.org/428612
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f2bb08ed6a114a2ceb4ff958db50485fd20c8206
Submitter: Jenkins
Branch:    master

commit f2bb08ed6a114a2ceb4ff958db50485fd20c8206
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Tue Jan 24 15:12:51 2017 +0800

    Raise correct error instead of class exist in Placement API
    
    When create resource class using placement API, and at
    the DB layer, we have a retry logic for 100 loop, and
    error will raise when the retry limit exceed, currently
    a log about limit exceed is generated but a
    ResourceClassExists Error is raised, which is a little
    bit weird and might confuse the users.
    
    We'd better add a particular Exception for this kind of
    scenario and it could be used in other places also.
    
    Co-Authored-By: huangtianhua@xxxxxxxxxx
    Closes-Bug: #1658868
    
    Change-Id: I89156be82ad520bdeacb12b31b44e7170b77ce3f


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1658868

Title:
  Should raise retry limit exceed error instead of class exist in
  Placement API

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When create resource class using placement API, and at the DB layer, we have a retry
  logic for 100 loop, and error will raise when the retry limit exceed, currently a log
  about limit exceed is generated but a ResourceClassExists Error is raised, which is a
  little bit wired and might confusing the users.

  We'd better add a particular Exception for this kind of scenario and it could be used
  in other places also.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1658868/+subscriptions


References