yahoo-eng-team team mailing list archive

[OpenStack Infra <1628455@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/380329
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2c54cc22ef8f9f0eb29eb0a7f8372dee515d4e25
Submitter: Jenkins
Branch:    master

commit 2c54cc22ef8f9f0eb29eb0a7f8372dee515d4e25
Author: Thomas Morin <thomas.morin@xxxxxxxxxx>
Date:   Fri Sep 30 16:07:20 2016 +0200

    OpenFlowSwitchMixin: do not override delete_flows
    
    With this change the delete_flow variant implementation
    of OpenFlowSwitchMixin, which was overriding the parent implementation
    from ovs_lib in an incompatible way using the native ryu implementation,
    is renamed into uninstall_flows.
    
    As discussed in bug 1628455, the approach consisting in
    extending the _keyword dict to convert ovs-ofctl rules into ryu
    parameters does not seem practical.
    
    This change also updates calls to delete_flows so that, when
    enabled, the native interface will be used.  Similar calls outside neutron
    repo need to be updated as well, which will be done in separate changes.
    
    Change-Id: I90ff1055d367609694eef975c7d084e4cd7a2cf4
    Closes-Bug: 1628455
    Needed-By: Idd2315565cc9c88319984d83487148bf498e91ab


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1628455

Title:
  openvswitch native bridge implementation redefines delete_flows with a
  different signature

Status in neutron:
  Fix Released

Bug description:
  The delete_flows method [1] in the native implementation of OVSBridge
  takes different parameters (including ryu objects) compared to with
  parent class method [2].

  As a result an agent extension reusing such a bridge will fail to call
  delete_flows depending on which flavor (native or ovs-ofctl) the agent
  is configured for.

  [1]
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py#L102

  [2]
  https://github.com/openstack/neutron/blob/master/neutron/agent/common/ovs_lib.py#L301

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1628455/+subscriptions