yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #61940
[Bug 1655393] Re: manila-ui quotas override part of the default quotas
Reviewed: https://review.openstack.org/418868
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4958805863df463cebb79b0175fa2fe8cbb83c5e
Submitter: Jenkins
Branch: master
commit 4958805863df463cebb79b0175fa2fe8cbb83c5e
Author: Itxaka <igarcia@xxxxxxxx>
Date: Wed Jan 11 12:23:18 2017 +0100
Merge "missing" quotas with nova quotas
There was an extra variable for the so called "missing"
quotas since 2013. This patch merges them with the
normal nova quotas, cleans up the tests, removes any
usage of that special var and as a side effect, adds
the missing keys to the project quota update page.
Change-Id: Icaac1ebb1749e13fdfc307e89dcc6bbd64bef922
Closes-Bug: 1655393
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1655393
Title:
manila-ui quotas override part of the default quotas
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Versions affected: mitaka and higher.
Under Admin -> Defaults -> Update defaults
Due to manila-ui overriding the default quotas from horizon, it makes the "Update Default Quotas" workflow miss some initial values ('Key Pairs' and 'Length of Injected File Path')
This is due to this line of code: https://github.com/openstack/manila-
ui/blob/stable/mitaka/manila_ui/dashboards/project/shares/__init__.py#L81
quotas.QUOTA_FIELDS = quotas.QUOTA_FIELDS + MANILA_QUOTA_FIELDS
This assumes that all the quotas available are in quotas.QUOTA_FIELDS but unfortunately, for some historical reason Im sure, there is some extra quotas not available on that tuple:
https://github.com/openstack/horizon/blob/master/openstack_dashboard/usage/quotas.py#L44
MISSING_QUOTA_FIELDS = ("key_pairs",
"injected_file_path_bytes",)
This causes the quotas to appear correctly when viewing them on Admin -> Defaults, but when editing their values get lost.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1655393/+subscriptions