yahoo-eng-team team mailing list archive

[OpenStack Infra <1658383@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/435858
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=56cc9ce14d5d84da562c282e672aedc57dd4dca6
Submitter: Jenkins
Branch:    master

commit 56cc9ce14d5d84da562c282e672aedc57dd4dca6
Author: Richard Jones <r1chardj0n3s@xxxxxxxxx>
Date:   Mon Feb 20 16:59:32 2017 +1100

    Fix hiding of selects when switchable
    
    Change-Id: I6e6ddefa6f1dcef6b8f1500ec5f09e73d3f0545f
    Closes-Bug: 1658383


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1658383

Title:
  while I choosing “volume” for “image source” ， "Type" can't be hide

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  the problem is found in newton-master

  while creating volume, because of the "class" of "image source" lack
  of  "switchable"， while I choosing “volume” for “image source” ,
  "Type" can't be hide.

  I think that there is something error here in the file"horizon/templates/horizon/common/fields/_themable_select.html":
    <select
      {% if id %}
        id="{{ id }}"{% endif %}
      {% if name %}
        name="{{ name }}"
      {% endif %}
      {% for k,v in select_attrs.items %}
        {% if k != 'class' %}
          {{ k|safe }}="{{ v }}"
        {% endif %}
      {% endfor %}

  class="form-control switchable" will not be set to "image source", something is modified like this, it's Ok:
    <select
      {% if id %}
        id="{{ id }}"{% endif %}
      {% if name %}
        name="{{ name }}"
      {% endif %}
      {% for k,v in select_attrs.items %}
        {% if k != 'class' or 'switch' in v %}
          {{ k|safe }}="{{ v }}"
        {% endif %}
      {% endfor %}

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1658383/+subscriptions