yahoo-eng-team team mailing list archive

[OpenStack Infra <1561193@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/341114
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=180a0d1da7b6b1da1bfbe2d0fae4f039b778ed68
Submitter: Jenkins
Branch:    master

commit 180a0d1da7b6b1da1bfbe2d0fae4f039b778ed68
Author: Yosef Hoffman <yh128t@xxxxxxx>
Date:   Wed Jun 29 05:51:49 2016 -0400

    Close modals with ESC key
    
    Currently, when the user opens a modal window and clicks on an element
    that is NOT a form input and tries to close the modal window by pressing
    the ESC key, the modal window will not close. This patch allows the user
    to close modals by pressing the ESC key no matter what element on the
    page has the focus.
    
    The fix is taken from https://getbootstrap.com/javascript/#live-demo
    
    Co-Authored-By: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
    
    Change-Id: I4d19fb400dee8132d9d490507c06989c07ce42ac
    Closes-Bug: #1561193


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1561193

Title:
  Modal windows don't close with ESC key in at least one scenario

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When the user opens a modal window and clicks on an element that is
  NOT a form input and tries to close the modal window pressing the ESC
  key, the modal window will not close.

  How to reproduce:
  1. Open a modal window, e.g. Try to create a new volume, instance or image.
  2. Click on an element that is NOT a form input,  e.g "Description Text", or a white space or any other element that makes inputs to lose focus.
  3. Press the ESC key and the modal window won't close.

  The modal window DO close if a form input has focus, but if any of
  those elements loses focus then using ESC key to close the window will
  not work.

  UPDATE #1: Pressing ESC key when creating instances does seem to work.
  But still the other behavior exists When creating volumnes or images.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1561193/+subscriptions