yahoo-eng-team team mailing list archive

[OpenStack Infra <1670868@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/442853
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=9ab80c7d9814b4db6b4a75ff5693bfa7a8076853
Submitter: Jenkins
Branch:    master

commit 9ab80c7d9814b4db6b4a75ff5693bfa7a8076853
Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxx>
Date:   Tue Mar 7 23:05:06 2017 +0000

    Revert "Fix RPC scale issue using cast instead of fanout v1"
    
    This reverts commit da425fd913c168d5477588df5d8574fce21e2eb7.
    
    - It has a wrong assumption that all L3 plugins have get_l3_agents_hosting_routers
    
    - It changes the signature of FirewallAgentApi in
      incompatible way and thus broke the way
      networking-midonet's firewall plugin is implemented. [1]
    
    [1] https://docs.openstack.org/developer/networking-midonet/devref/firewall.html
    
    I'd suggest to push _get_hosts_to_notify logic
    into FirewallAgentApi itself.
    
    Change-Id: Ib2b5d26ac12b2064f7d6142652e6625791053e39
    Closes-Bug: #1670868


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1670868

Title:
  AttributeError: 'MidonetL3ServicePlugin' object has no attribute
  'get_l3_agents_hosting_routers'

Status in networking-midonet:
  New
Status in neutron:
  Fix Released

Bug description:
  neutron-fwaas should not assume L3 plugin has get_l3_agents_hosting_routers.
  the assumption was introduced by Id6cb991aee959319997bb15ece240c09d4ac5e39 .
  MidonetL3ServicePlugin doesn't have it.

  eg. http://logs.openstack.org/92/440892/1/check/gate-networking-
  midonet-python27-ubuntu-xenial/6a4b725/testr_results.html.gz

  Traceback (most recent call last):
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/api/v2/resource.py", line 79, in resource
      result = method(request=request, **args)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/api/v2/base.py", line 436, in create
      return self._create(request, body, **kwargs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/db/api.py", line 93, in wrapped
      setattr(e, '_RETRY_EXCEEDED', True)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/db/api.py", line 89, in wrapped
      return f(*args, **kwargs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 151, in wrapper
      ectxt.value = e.inner_exc
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 139, in wrapper
      return f(*args, **kwargs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/db/api.py", line 129, in wrapped
      traceback.format_exc())
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/db/api.py", line 124, in wrapped
      return f(*dup_args, **dup_kwargs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/api/v2/base.py", line 549, in _create
      obj = do_create(body)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/api/v2/base.py", line 531, in do_create
      request.context, reservation.reservation_id)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.zBhXnCshkM/openstack/neutron/neutron/api/v2/base.py", line 524, in do_create
      return obj_creator(request.context, **kwargs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.ahfzmovvD0/openstack/neutron-fwaas/neutron_fwaas/services/firewall/fwaas_plugin.py", line 277, in create_firewall
      hosts = self._get_hosts_to_notify(context, fw_new_rtrs)
    File "/home/jenkins/workspace/gate-networking-midonet-python27-ubuntu-xenial/.tmp/tmp.ahfzmovvD0/openstack/neutron-fwaas/neutron_fwaas/services/firewall/fwaas_plugin.py", line 175, in _get_hosts_to_notify
      nl_constants.L3).get_l3_agents_hosting_routers(
  AttributeError: 'MidonetL3ServicePlugin' object has no attribute 'get_l3_agents_hosting_routers'

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-midonet/+bug/1670868/+subscriptions