yahoo-eng-team team mailing list archive

[Mateusz Kowalski <mateusz.kowalski@xxxxxxx>]

s/patch/path in the bug title...

** Also affects: xstatic-roboto-fontface
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1671004

Title:
  Wrong patch for Roboto fontfiles

Status in OpenStack Dashboard (Horizon):
  New
Status in xstatic-roboto-fontface:
  New

Bug description:
  On the filesystem fonts are available under
  lib/roboto_fontface/fonts/**roboto**/**Roboto**-Regular.woff2 whereas
  in https://github.com/choffmeister/roboto-fontface-
  bower/blob/master/css/mixins.scss#L5 $variant is used twice, but in
  both cases the first letter has a different case-sensitivity.

  In the correct case we would like to have $font-full-path: '#{$roboto-
  font-path}/roboto/Roboto'; which means the same variable $variant
  cannot be used twice.

  I would see something like $font-full-path: '#{$roboto-font-path
  }/#{to-lower-case($variant)}/#{$variant}'; as a fix to this problem.
  The file https://github.com/choffmeister/roboto-fontface-
  bower/blob/master/css/mixins.less#L5 should be patched in a similar
  way for consistency, but as Material design does not use LESS, only
  SCSS, it does not affect functionality.

  Please note this bug affects everyone using Material design out-of-
  the-box in stable/ocata.

  In case of patching upper-constraints.txt?h=stable/ocata should also
  be fixed as it now contains XStatic-roboto-fontface===0.5.0.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1671004/+subscriptions