← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1635182] Re: [placement] in api code repeated need to restate json_error_formatter is error prone

 

Reviewed:  https://review.openstack.org/433301
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=db5b1603282b4bb7665670c539d224c42dee8a9d
Submitter: Jenkins
Branch:    master

commit db5b1603282b4bb7665670c539d224c42dee8a9d
Author: Pushkar Umaranikar <pushkar.umaranikar@xxxxxxxxx>
Date:   Mon Feb 13 22:22:24 2017 +0000

    Placement api: set custom json_error_formatter in root
    
    Change decorator for resource based actions in root
    handler to wsgi_wrapper.PlacementWsgify
    
    This is a newly introduced wrapper class around webob.dec.wsgify
    to set json formatter in case of webob exceptions.
    
    Change-Id: I847345f7f15a46930faf8793baf801beba98d368
    Closes-Bug: #1635182


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1635182

Title:
  [placement] in api code repeated need to restate json_error_formatter
  is error prone

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Any time placement API (v1.0) code wants to raise a webob.exc of some
  kind it needs to add a json_formatter attribute to the call. This is
  easy to forget. We can probably figure out a way to make this a
  default, perhaps by making subclasses of the existing exceptions or
  setting some defaults somewhere. Not a huge deal but worth looking
  into.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1635182/+subscriptions


References