← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1655727] Re: Improve compatibility with eventlet 0.20.1

 

Reviewed:  https://review.openstack.org/419074
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f07c7cff61a3a6a326fde699af3a800d1ac7d571
Submitter: Jenkins
Branch:    master

commit f07c7cff61a3a6a326fde699af3a800d1ac7d571
Author: Dirk Mueller <dirk@xxxxxxxx>
Date:   Wed Jan 11 19:02:52 2017 +0100

    Invoke monkey_patching early enough for eventlet 0.20.1
    
    eventlet 0.20.x is monkey patching also subprocess, so we need
    to establish patching early enough for functional tests
    
    Closes-Bug: #1655727
    Change-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f


** Changed in: glance
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1655727

Title:
  Improve compatibility with eventlet 0.20.1

Status in Glance:
  Fix Released

Bug description:
  Eventlet 0.20.x added support for green version of subprocess, which
  however causes an issue with glance tests:

  glance.tests.functional.db.test_registry.TestRegistryDriver.test_image_create_bad_property
  ------------------------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "glance/tests/functional/db/test_registry.py", line 74, in setUp
          super(TestRegistryDriver, self).setUp()
        File "glance/tests/functional/db/base.py", line 95, in setUp
          super(TestDriver, self).setUp()
        File "glance/tests/functional/db/test_registry.py", line 62, in setUp
          api_version=2)
        File "glance/tests/functional/__init__.py", line 765, in start_with_retry
          **kwargs)
        File "glance/tests/functional/__init__.py", line 148, in start
          self.create_database()
        File "glance/tests/functional/__init__.py", line 230, in create_database
          expect_exit=True)
        File "glance/tests/utils.py", line 318, in execute
          result = process.communicate()
        File "/usr/lib64/python2.7/subprocess.py", line 800, in communicate
          return self._communicate(input)
        File "/usr/lib64/python2.7/subprocess.py", line 1417, in _communicate
          stdout, stderr = self._communicate_with_poll(input)
        File "/usr/lib64/python2.7/subprocess.py", line 1447, in _communicate_with_poll
          poller = select.poll()
      AttributeError: 'module' object has no attribute 'poll'

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1655727/+subscriptions


References