yahoo-eng-team team mailing list archive

[OpenStack Infra <1670642@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/441989
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d629d4e42c04756444a79e9ac15f3f2192c47b52
Submitter: Jenkins
Branch:    master

commit d629d4e42c04756444a79e9ac15f3f2192c47b52
Author: Evgeny Antyshev <eantyshev@xxxxxxxxxxxxx>
Date:   Mon Mar 6 14:27:06 2017 +0000

    get_model method missing for Ploop image
    
    Image.get_model is called in partition injection code,
    and now inject partition attempt fails unconditionally.
    This patch makes use of disk/api.py inject_data failure tolerance:
    it doesn't fail unless injected data is mandatory.
    
    Closes-Bug: 1670642
    Change-Id: I6c68693be818219f78d6fcda019b867066396b29


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1670642

Title:
  get_model method missing for Ploop image

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  This results in failures in inject_data from nova/virt/disk/api.py
  even if no real data is injected:

  2017-03-03 15:11:55.707 48683 ERROR nova.virt.libvirt.driver [req-f6f3df11-35b0-44c2-a1c4-52548504a1b5 fd33deabe809466a8dcd517bdf882e6b e4046b10f1074f06bd5d474ddfce09bc - - -] [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5] Error injecting data into image 082f0243-cd99-4312-a27a-86b8cd3688d2 ()
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [req-f6f3df11-35b0-44c2-a1c4-52548504a1b5 fd33deabe809466a8dcd517bdf882e6b e4046b10f1074f06bd5d474ddfce09bc - - -] [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5] Instance failed to spawn
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5] Traceback (most recent call last):
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 2078, in _build_resources
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     yield resources
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 1920, in _build_and_run_instance
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     block_device_info=block_device_info)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2624, in spawn
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     admin_pass=admin_password)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 3028, in _create_image
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     fallback_from_host)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 3137, in _create_and_inject_local_root
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     files)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2977, in _inject_data
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     instance=instance)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     self.force_reraise()
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     six.reraise(self.type_, self.value, self.tb)
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2968, in _inject_data
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     disk_api.inject_data(injection_image.get_model(self._conn),
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]   File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/imagebackend.py", line 395, in get_model
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]     raise NotImplementedError()
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5] NotImplementedError
  2017-03-03 15:11:55.708 48683 ERROR nova.compute.manager [instance: 99aaeae0-e611-424e-bbd6-8d83ef37caf5]

  libvirt.virt_type              = parallels
  libvirt.images_type            = ploop
  libvirt.inject_partition       = -1

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1670642/+subscriptions