yahoo-eng-team team mailing list archive

[Chris Dent <cdent+lp@xxxxxxxxxxxxx>]

Public bug reported:

The placement API a guarding condition which checks the request method.
If it is PUT, POST or PATCH the presence of a content-type header is
required.

This is too strict (but happened to work fine for the api at the time).
It is reasonable and okay to make a PUT or POST without a body, and thus
without a content-type, and now we want to do such things within the
placement API (with putting custom traits and resource classes).

The fix is to only raise the 400 when content-length is set and non-
zero. In that case a missing content-type is a bug, irrespective of
method.

** Affects: nova
     Importance: Undecided
     Assignee: Chris Dent (cdent)
         Status: In Progress


** Tags: placement

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1674392

Title:
  placement api requires content-type on put and post even when no body

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  The placement API a guarding condition which checks the request
  method. If it is PUT, POST or PATCH the presence of a content-type
  header is required.

  This is too strict (but happened to work fine for the api at the
  time). It is reasonable and okay to make a PUT or POST without a body,
  and thus without a content-type, and now we want to do such things
  within the placement API (with putting custom traits and resource
  classes).

  The fix is to only raise the 400 when content-length is set and non-
  zero. In that case a missing content-type is a bug, irrespective of
  method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1674392/+subscriptions