yahoo-eng-team team mailing list archive

[OpenStack Infra <1673301@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/446279
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9a2979557d71f7acc4fd27c748201d9795d9e7fd
Submitter: Jenkins
Branch:    master

commit 9a2979557d71f7acc4fd27c748201d9795d9e7fd
Author: ZhangHongtao <zhanghongtao0826@xxxxxxx>
Date:   Thu Mar 16 10:14:03 2017 +0800

    Remove x-subject-token in api-ref for v3/auth/catalog
    
    Only x-auth-token is required for these api calls, but the
    api-ref mentions x-subject-token as required also.
    This fixes that by removing x-subject-token from the call docs.
    
    Change-Id: I26342250c74918c21fce951bf0706d50141aa58c
    Closes-Bug: 1673301


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1673301

Title:
  [api] In the API "GET /v3/auth/catalog", the parameter "X-Subject-
  Token" is unused, it is redundant.

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Like the summary said, "X-Subject-Token" is unused, we need remove it
  from API reference document. The source code about API follows is
  below [0]:

  @controller.protected()
  def get_auth_projects(self, request):
      user_id = request.auth_context.get('user_id')
      group_ids = request.auth_context.get('group_ids')

      user_refs = []
      if user_id:
          try:
              user_refs = self.assignment_api.list_projects_for_user(user_id)
          except exception.UserNotFound:  # nosec
              # federated users have an id but they don't link to anything
              pass

      grp_refs = []
      if group_ids:
          grp_refs = self.assignment_api.list_projects_for_groups(group_ids)

      refs = self._combine_lists_uniquely(user_refs, grp_refs)
      return resource_controllers.ProjectV3.wrap_collection(
          request.context_dict, refs)

  "request.auth_context" is based on "X-Auth-Token", not "X-Subject-
  Token".

  
  [0] https://github.com/openstack/keystone/blob/1909ef496c11c51e0035237194b5b8717c6ad6e6/keystone/auth/controllers.py#L361-L380

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1673301/+subscriptions