yahoo-eng-team team mailing list archive

[OpenStack Infra <1674961@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/448655
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=300e64f84fff086a5ed2ee0c45d539e3268efc68
Submitter: Jenkins
Branch:    master

commit 300e64f84fff086a5ed2ee0c45d539e3268efc68
Author: Gábor Antal <antal@xxxxxxxxxxxxxxx>
Date:   Wed Mar 22 16:11:43 2017 +0100

    Ensure instance is in active state after notification test
    
    In versioned notification tests, we should ensure that after
    testing a notification in test_instance_action, the instance is in
    active state.
    
    Currently, there is no guarantee that instance left in active state
    after a notification test. In this patchset, it is ensured, and the
    notifications, which violates this rule, are refactored.
    
    Change-Id: Iff0012a4065e61111b69c96e1a4f2074340d9c41
    Co-Authored-By: Béla Vancsics <vancsics@xxxxxxxxxxxxxxx>
    Implements: bp versioned-notification-transformation-pike
    Closes-Bug: #1674961


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1674961

Title:
  Instances are not left in active state after a notification test

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  As a notification transformation guideline in [1] explains that each
  called test in test_instance_action should ensure that instance is
  left in ACTIVE state after a notification test. However currently it
  is not ensured, thus some of the test does not even care about it
  (like suspend, pause actions).

  This can cause problems, which can be seen at [2]. In the future, we
  should ensure that after a test, the instance is in active state.

  [1]: https://github.com/openstack/nova/blob/39cd54091747723a392dc33a2b5d6f5a28b537a7/nova/tests/functional/notification_sample_tests/test_instance.py#L57
  [2]: https://review.openstack.org/#/c/396225/21

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1674961/+subscriptions