yahoo-eng-team team mailing list archive

[OpenStack Infra <1647432@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/407099
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=977d254cc69915819cf4226dc8cfc8c36969735b
Submitter: Jenkins
Branch:    master

commit 977d254cc69915819cf4226dc8cfc8c36969735b
Author: John Schwarz <jschwarz@xxxxxxxxxx>
Date:   Mon Dec 5 14:15:17 2016 +0200

    Throttle SIGHUPs to keepalived
    
    Multiple SIGHUPs in quick succession might cause the master keepalived
    to forfeit its mastership (which will cause keepalived to remove IPs of
    its external devices, severing connectivity). This can happen when, for
    example, associating or disassociating multiple floatingips.
    
    The patch makes the agent throttle SIGHUP sent to keepalived: the very first
    SIGHUP is always sent; as for subsequent signals, they are delayed till
    agent threshold is reached. (It's 3 seconds by default.)
    
    As an example, when three consequent router updates trigger keepalived
    respawn then:
    * the very first signal is sent as usual;
    * the second signal is deferred and sent in up to 3 seconds since the
      first signal;
    * the third signal is ignored, though the change that triggered it will
      be correctly applied by the second signal handler when it is triggered
      after threshold delay.
    
    If the last time a spawn request occurred is older than current-time
    minus threshold then there is no delay.
    
    Co-Authored-By: Jakub Libosvar <libosvar@xxxxxxxxxx>
    Co-Authored-By: Cedric Brandily <zzelle@xxxxxxxxx>
    Co-Authored-By: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
    
    Closes-Bug: 1647432
    Change-Id: I2955e0de835458a2eea4dd088addf33b656f8670


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1647432

Title:
  Multiple SIGHUPs to keepalived might trigger re-election

Status in neutron:
  Fix Released

Bug description:
  As the title says, multiple SIGHUPs that are sent to the keepalived
  process might cause it to forfeit mastership and re-negotiate a new
  master (which might be the original master). This means that when, for
  example, associating/disassociating 2 floatingips in quick succession
  (each triggers a SIGHUP), the master node will forfeit re-election
  (causing it to switch to BACKUP, thus removing all the remaining FIP's
  IPs and severing connectivity.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1647432/+subscriptions